Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vastly improve frontend-part of the search (current one is only "proof of concept") #620

Closed
LukasKalbertodt opened this issue Dec 5, 2022 · 3 comments
Labels
area:frontend Everything frontend related area:search Related to Tobira's search kind:improvement

Comments

@LukasKalbertodt
Copy link
Member

Unfortunately, the current frontend part of the search functionality is still in its original "proof of concept" form. In other word: it's bad. It looks bad, it has surprising behavior (can't "close" the search, ...), has several bugs, and all of that. The code structure is also not ideal, I think.

We really have to take a good look at that again to make it look pretty and more functional. Pagination and filtering should also be considered (albeit not necessarily implemented right away).

Here are some random notes I collected on this topic:


Some style examples we could use as basis: one, two.

  • Probably just make search a proper overlay over the current route (and make query parameter search the trigger)
  • Put the video thumbnails on the right side
  • Have an icon for video/page/series on the left somewhere so that it's easy to see what kind of item you are seeing
  • separate creators with dot icon, not comma
  • show video timestamp
  • if there is no creator, dont show creator
@owi92
Copy link
Member

owi92 commented Nov 29, 2023

Have an icon for video/page/series on the left somewhere so that it's easy to see what kind of item you are seeing

One thing to note here is that currently, we only search for events and realms (aka pages) and not series. Sure, many series have their own realm, but I don't think it's possible to easily infer whether that realm has any other content.
So if we want to include every series, I think the we need to modify the search to also include "direct link" series pages.

@oas777
Copy link
Collaborator

oas777 commented Nov 29, 2023

If we have to prioritise (and I think we have to) I would skip searching both series and content pages and focus on "video search" (including metadata). To me, integrating

  • slide content,
  • subtitles, and
  • displaying search results along a video timeline
    are more relevant.

TBD.

@LukasKalbertodt
Copy link
Member Author

Done in #1025

Well, not everything obviously but this issue was about replacing the "proof of concept" search. Further features are tracked in separate issues.

@github-project-automation github-project-automation bot moved this from Todo to Done ✔️ in Tobira Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend Everything frontend related area:search Related to Tobira's search kind:improvement
Projects
Status: Done ✔️
Development

No branches or pull requests

3 participants