You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would like your input about if this is intended, if I could open a PR that either allow "quiet" to be changed, or if "true" should be the default value (or both).
For the record, the quiet option has been added in #8 by @malept 8 years ago.
The text was updated successfully, but these errors were encountered:
I also agree that this should have been an optional parameter that could have been set by the config. I dealt with a lot of issues that I had no starting point for, only seeing this issue let me create a shim to override it. This would have saved me a lot of time. I also don't understand the decision to have Continue on error forced on Osx sign then to continue onto OSx-notarize. You will NEVER be able to notarize a package with a failed codesign output, and in my opinion it should just throw an error there.
Pre-flight checklist
Electron Forge version
7.2.0
Electron version
28.2.3
Operating system
macOS 14.3.1
Last known working Electron Forge version
No response
Expected behavior
I'd like the
packagerConfig.quiet
to be default totrue
, or at least to let me change it's value.Actually it's "locked" by the following lines :
forge/packages/api/core/src/api/package.ts
Lines 305 to 317 in 3c5bf3d
(both lines 305 and 317 do force the value to
false
after the custom user configuration).Actual behavior
When trying to sign the app, I got issues that I could not debug without having to go deep into the code and
console.log
thingsI used both
DEBUG=electron-osx-sign*
andDEBUG=electron-notarize*
, but I still struggled at some point (see below).Steps to reproduce
I do not know if you can reproduce this, but I can show the deep dive I had to do (quick version).
For the record, with the same configuration, I had no issue on a mac "x64".
When trying to sign and notarize a mac app, when running
yarn make
, I got the following outputBy running with
DEBUG=electron-osx-sign*
, the last log I got wasWalking...
from https://github.com/electron/osx-sign/blob/97b1e13b9a6de43a5add8dccf609ac10a780b1e8/src/util.ts#L136I tried adding a line just bellow and nothing was displayed.
I added a
try / catch
, and then I got an issue displayed withEMFILE: too many open files
(but that's not the point of this issue).By going up with this, I found that all error send in the signApp, will be throwned to the caller (as mentioned in the documentation).
I then went into the packager package, that does call
signApp
here where there is acontinueOnError
optionhttps://github.com/electron/packager/blob/d5cd2b7dcd8e85c1c1bdcdd3c4e77edc9ac729f2/src/mac.ts#L404-L414
I tried to add this option into my
osxSign
option, but TypeScript does throw withI continue to dive as I did not saw neither the error, nor the warning message "Code sign failed; please retry manually"
In the warning function, we do nothing when the
quiet
option is true : https://github.com/electron/packager/blob/d5cd2b7dcd8e85c1c1bdcdd3c4e77edc9ac729f2/src/common.ts#L30I tried to set the
quiet
option in mypackagerConfig
object. TypeScript is OK with this, still no log.As I said in the "Expected behavior" section, it's locked here
forge/packages/api/core/src/api/package.ts
Lines 305 to 317 in 3c5bf3d
Additional information
I would like your input about if this is intended, if I could open a PR that either allow "quiet" to be changed, or if "true" should be the default value (or both).
For the record, the
quiet
option has been added in #8 by @malept 8 years ago.The text was updated successfully, but these errors were encountered: