Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

Fix token prices of non-mainnet chains #176

Closed
2 tasks
sandford-ch opened this issue Dec 1, 2023 · 2 comments · Fixed by #204
Closed
2 tasks

Fix token prices of non-mainnet chains #176

sandford-ch opened this issue Dec 1, 2023 · 2 comments · Fixed by #204
Assignees
@filo87
Labels
Bug Issue describing a bug

Comments

@sandford-ch
Copy link

Acceptance criteria

  • (Given)/(When)/(Then)
  • (Given)/(When)/(Then)
@sandford-ch
Copy link
Author

@hieronx : Could you please specify a bit more, what needs fixing re non-mainnet token prices? :) Either here or also in your original ticket: centrifuge#76

@hieronx
Copy link

hieronx commented Dec 1, 2023

centrifuge#73 this PR hardcoded a change for token price decimals that should only apply to Centrifuge mainnet, but currently applies to all networks

@filo87 filo87 added the Bug Issue describing a bug label Dec 11, 2023
@filo87 filo87 self-assigned this Feb 7, 2024
filo87 added a commit that referenced this issue Feb 7, 2024
@filo87
fix: fix token prices of non-mainnet chains
7759836 
Fixes #176
@filo87 filo87 mentioned this issue Feb 7, 2024
Merged
filo87 added a commit that referenced this issue Feb 7, 2024
@filo87
fix token prices of non-mainnet chains (#204)
23fe03b 
* fix: fix token prices of non-mainnet chains
Fixes #176

* fix: tests require chainId global
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@filo87 filo87

Labels
Bug Issue describing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix token prices of non-mainnet chains embrio-tech/centrifuge-subql
3 participants
@hieronx @filo87 @sandford-ch