Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix to DB_Column visualization #12245

Merged
merged 2 commits into from
Feb 8, 2025
Merged

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Feb 6, 2025

Pull Request Description

image

  • Fixes Visualizing a Vector that contains a DB_Column crashes the visualization #12244
  • I thought that it may make sense to distinguish DB from in-memory columns in visualization so added the DB_ prefix in the visualization.
  • For more nested (not shown on screenshot) DB_Column/DB_Table we don't fetch the row count as that is a costly operation.
  • For unnested we still fetch (although open to changing that), but do not fetch the items for DB_Column - just display the row count.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label Feb 6, 2025
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Feb 6, 2025
@AdRiley AdRiley added the CI: Keep up to date Automatically update this PR to the latest develop. label Feb 8, 2025
@AdRiley AdRiley removed the CI: Keep up to date Automatically update this PR to the latest develop. label Feb 8, 2025
@jdunkerley jdunkerley added CI: Keep up to date Automatically update this PR to the latest develop. and removed CI: Keep up to date Automatically update this PR to the latest develop. labels Feb 8, 2025
@mergify mergify bot merged commit f419a12 into develop Feb 8, 2025
47 checks passed
@mergify mergify bot deleted the wip/radeusgd/vis-db-column branch February 8, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visualizing a Vector that contains a DB_Column crashes the visualization
4 participants