Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add secret enum in envoyPatchPolicy #5268

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Feb 13, 2025

Fixes: #5200

@arkodg arkodg requested a review from a team as a code owner February 13, 2025 00:15
@arkodg arkodg requested a review from a team February 13, 2025 00:16
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.97%. Comparing base (df29847) to head (904b88a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5268   +/-   ##
=======================================
  Coverage   67.97%   67.97%           
=======================================
  Files         214      214           
  Lines       33522    33522           
=======================================
+ Hits        22785    22786    +1     
+ Misses       9352     9351    -1     
  Partials     1385     1385           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zirain
zirain previously approved these changes Feb 13, 2025
Xunzhuo
Xunzhuo previously approved these changes Feb 14, 2025
@zirain
Copy link
Member

zirain commented Feb 14, 2025

why gen-check failed after rebased from main.

@arkodg arkodg dismissed stale reviews from Xunzhuo and zirain via 904b88a February 14, 2025 21:27
@arkodg arkodg enabled auto-merge (squash) February 14, 2025 21:39
@arkodg arkodg merged commit 8ea091c into envoyproxy:main Feb 14, 2025
26 of 27 checks passed
@arkodg arkodg deleted the fix-enum branch February 14, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to inject credentials into a proxied request
5 participants