Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating point arithmetic and precision #192

Open
ErlendHaa opened this issue Aug 17, 2023 · 0 comments
Open

Floating point arithmetic and precision #192

ErlendHaa opened this issue Aug 17, 2023 · 0 comments

Comments

@ErlendHaa
Copy link
Contributor

Our API, as well as OpenVDS's API operate primarily on floats. However, we do a lot of intermediate floating point arithmetic before we pass values along to OpenVDS. E.g. coordinate transformations. To avoid precision loss (accumulating precision loss) we do most of these calculations on double and convert back to float only when passing the values along to OpenVDS. However, this annotation to voxel transform computes on floats, and when used here it introduces a precision loss to the surface depths we are fetching from OpenVDS.

To fix this we should do this annotation to voxel transformation on doubles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant