You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The MantisBT project has been using awesome Parsedown 1.7.4 for a long time and now we are trying to upgrade to latest version i.e. 1.8, but unexpectedly we found a regression in the tests.
Further investigation revealed that the commit eb55e42 (1.7.1 -> 1.8) removed the use of the unmarkedText() method, although the method itself remains and is not used anywhere else.
The problem is that MantisBT uses this overloaded method to extend syntax to mark up an email without angle brackets.
If it is possible to get some insight into whether this is a bug that needs to be fixed or just leftover unnecessary code (which, if true, would break the class interface), that would be greatly appreciated. This would help us plan the development of MantisBT.
The text was updated successfully, but these errors were encountered:
dregad
pushed a commit
to mantisbt/mantisbt
that referenced
this issue
Jan 26, 2025
MantisMarkdown class overloads the Parsedown unmarkedText() method, to
extend syntax to mark up an email without angle brackets.
Parsedown 1.8 [1] removed the use of the unmarkedText() method, although
the method itself remains and is not used anywhere else. This has been
reported upstream [2].
This commit implements an alternative approach to parsing emails, which
makes us independent from this particular Parsedown issue.
Fixes #25227
[1]: erusev/parsedown@eb55e42
[2]: erusev/parsedown#898
The MantisBT project has been using awesome Parsedown 1.7.4 for a long time and now we are trying to upgrade to latest version i.e. 1.8, but unexpectedly we found a regression in the tests.
Further investigation revealed that the commit eb55e42 (1.7.1 -> 1.8) removed the use of the
unmarkedText()
method, although the method itself remains and is not used anywhere else.The problem is that MantisBT uses this overloaded method to extend syntax to mark up an email without angle brackets.
If it is possible to get some insight into whether this is a bug that needs to be fixed or just leftover unnecessary code (which, if true, would break the class interface), that would be greatly appreciated. This would help us plan the development of MantisBT.
The text was updated successfully, but these errors were encountered: