Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evmone exports currentBaseFee on legacy forks #1073

Closed
winsvega opened this issue Nov 28, 2024 · 0 comments · Fixed by #1075
Closed

evmone exports currentBaseFee on legacy forks #1073

winsvega opened this issue Nov 28, 2024 · 0 comments · Fixed by #1075
Assignees
@chfast
Labels
tests Testing infrastructure

Comments

@winsvega
Copy link

ethereum/execution-spec-tests#968

due to the way pyspec is constructing tests. this return leads to invalid test generation
such issue happens:

src/ethereum_test_fixtures/verify_format.py:28: in verify_blockchain_fixture_json
    raise Exception(
E   Exception: Error in generated blockchain test json (tests/frontier/opcodes/test_dup.py::test_dup[fork_Frontier-evm_code_type_LEGACY-blockchain_test-DUP1])[{"type":"extra_forbidden","loc":["baseFeePerGas"],"msg":"Extra inputs are not permitted","input":"0x00","url":"https://errors.pydantic.dev/2.9/v/extra_forbidden"}]

test is created with blockheader having this field on legacy forks.

other transition tools don't report this field on legacy fields.

we think evmone t8n should follow the majority of t8n's
@chfast chfast self-assigned this Dec 2, 2024
@chfast chfast added the tests Testing infrastructure label Dec 2, 2024
chfast added a commit that referenced this issue Dec 2, 2024
@chfast
t8n: Don't output currentBaseFee before London
9ec065d 
The parent/current base fee fields are related to EIP-1559 from London.
Don't place the default value of the `"currentBaseFee"` in the out.json
if the EVM revision is before London.

Fixes #1073.
@chfast chfast mentioned this issue Dec 2, 2024
Merged
chfast added a commit that referenced this issue Dec 2, 2024
@chfast
t8n: Don't output currentBaseFee before London (#1075)
612420e 
The parent/current base fee fields are related to EIP-1559 from London.
Don't place the default value of the `"currentBaseFee"` in the out.json
if the EVM revision is before London.

Fixes #1073.
@winsvega winsvega mentioned this issue Dec 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chfast chfast

Labels
tests Testing infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

t8n: Don't output currentBaseFee before London ethereum/evmone
2 participants
@chfast @winsvega