-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools vs. Actions #671
Comments
I created a Google table with all the documented (sub)commands and brainsstormed possible action names for those that don't have one yet: |
If this is done a a part of a major fastlane version, one could very much use the opportunity to get rid of many "tool" folders in fastlane/fastlane and convert them to simple actions. (Some of the old tools probably have some additional logic in their folders that would have to be taken care of [e.g. Android library for |
…stlane supply init` does as a command (#13113) This is a proof of concept for one of the ideas I suggested in fastlane/docs#671: adding actions for all the `fastlane <toolname> init` commands that do more than creating a config file. - Similar to `upload_to_play_store` this is a thin wrapper around the code that is already present in `supply`. - To make the options list more manageable, I hardcoded a manual list of options this action actually needs and removed all the others. - As the action doesn't contain its actual code, I had to exclude it from the check in `fastlane/spec/unused_options_spec.rb` as well.
…stlane supply init` does as a command (fastlane#13113) This is a proof of concept for one of the ideas I suggested in fastlane/docs#671: adding actions for all the `fastlane <toolname> init` commands that do more than creating a config file. - Similar to `upload_to_play_store` this is a thin wrapper around the code that is already present in `supply`. - To make the options list more manageable, I hardcoded a manual list of options this action actually needs and removed all the others. - As the action doesn't contain its actual code, I had to exclude it from the check in `fastlane/spec/unused_options_spec.rb` as well.
After @taquitos and @joshdholtz convinced me that documenting the tools is not the way to go, I spent some time understanding what is still missing to fully transition from tools to actions.
Current state
fastlane gym
Gymfile
build_ios_app
(+gym
alias)fastlane run build_ios_app
Problems
gym
.vsgradle
)fastlane gym
) vs. run action (fastlane run build_ios_app
)SnapshotHelper.swift
init
subcommands don't exist as action conceptPossible Solutions
produce
, in the documentation for exampleConfigfile
that combines all of them?fastlane tool
andfastlane lane
, maybe alsofastlane action
?ScreenshotHelper.swift
init
. Just docs maybe? Magic action nameinit_build_ios_app
forbuild_ios_app
?Consequential work / problems
For reference:
List of tools and Configfiles in use:
https://github.com/fastlane/fastlane/blob/master/fastlane/lib/fastlane/tools.rb
The text was updated successfully, but these errors were encountered: