Rework time dilution in F3 tests and refine assertions #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masih
force-pushed
the
masih/fix-flaky-f3-teste
branch
2 times, most recently
from
84bdd9f to
3606fdd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #862 +/- ##
==========================================
- Coverage 67.16% 67.13% -0.03%
==========================================
Files 83 84 +1
Lines 9064 9129 +65
==========================================
+ Hits 6088 6129 +41
- Misses 2429 2456 +27
+ Partials 547 544 -3
|
|
Hold off on reviews until I crack the intermittent failures on CI. Regardless, early feedback is always welcomed 🙏 |
masih
force-pushed
the
masih/fix-flaky-f3-teste
branch
2 times, most recently
from
533d689 to
0791531
Compare
|
@Kubuxu this is ready for review whenever you get a chance. Thanks |
Kubuxu
approved these changes
Jan 31, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
masih
force-pushed
the
masih/fix-flaky-f3-teste
branch
from
0791531 to
8ad4a96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress the clock during tests independently of condition check. Rework the assertions to use built-in eventual assertion. Use consistent names for the asserting functions.
Fixes #818
Fixes #847