Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WASD inputs in matchmaking server text box move text cursor #933

Closed
MaxCWhitehead opened this issue Mar 23, 2024 · 1 comment · Fixed by #1023
Closed

WASD inputs in matchmaking server text box move text cursor #933

MaxCWhitehead opened this issue Mar 23, 2024 · 1 comment · Fixed by #1023
Labels
help wanted Extra attention is needed kind:bug Something isn't working scope:tiny A task that takes less than an hour topic:ui User interface.

Comments

@MaxCWhitehead
Copy link
Collaborator

MaxCWhitehead commented Mar 23, 2024 •
edited
Loading

Description

Need to disable WASD moving text cursor in this text box, makes it hard to type in. Pretty sure I saw the code to do this in some other menus, but need to track that down.

Maybe need to do something like this temporarily?

jumpy/src/ui/main_menu/player_select.rs

Lines 53 to 58 in dda2b2e

) {
let mut state = ui.ctx().get_state::<PlayerSelectState>();
ui.ctx().set_state(EguiInputSettings {
disable_keyboard_input: true,
disable_gamepad_input: true,
});

To Reproduce

Go to settings -> networking

Type letters A and D in matchmaking server text box, observe this moves cursor and messes up input.

Expected Behavior

No response

Additional Context

No response

Log Messages

No response
@MaxCWhitehead MaxCWhitehead added kind:bug Something isn't working topic:ui User interface. scope:tiny A task that takes less than an hour help wanted Extra attention is needed labels Mar 23, 2024
@nelson137 nelson137 mentioned this issue Sep 11, 2024
Merged
@MaxCWhitehead
Copy link
Collaborator Author

Commented on PR #1023 with some more info on changes for prospective fix

@nelson137 nelson137 mentioned this issue Oct 11, 2024
Merged
MaxCWhitehead pushed a commit to fishfolk/bones that referenced this issue Oct 11, 2024
@nelson137
feat(framework): make sure input structs impl Copy (#483)
016ed7e 
Very straightforward changes.

While working on [jumpy
#933](fishfolk/jumpy#933) I realized some of
these events don't `impl Copy`.
github-merge-queue bot pushed a commit that referenced this issue Oct 14, 2024
@nelson137 @MaxCWhitehead
fix(settings): networking tab input (#1023)
c9c3c8a 
Fixes #933 

Disabling only gamepad input seems to make the input behave as one would
expect. Arrow keys, backspace, etc work like normal, and bound keys
(e.g. A, D) only update the text and no longer move the caret.

Unfortunately I don't have a controller to test with, but I assume this
will work with those kind of inputs too.

---------

Co-authored-by: Max Whitehead <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed kind:bug Something isn't working scope:tiny A task that takes less than an hour topic:ui User interface.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(settings): networking tab input nelson137/jumpy
1 participant
@MaxCWhitehead