Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion about additional wrapperElement required #175

Closed
thg2k opened this issue Oct 14, 2011 · 4 comments
Closed

Discussion about additional wrapperElement required #175

thg2k opened this issue Oct 14, 2011 · 4 comments

Comments

@thg2k
Copy link

thg2k commented Oct 14, 2011

Hi fnagel, I'm using your selectmenu widget on a production website.

After 4 months I came back to your repository to merge latest changes, but the current version (ok it says "dev version" in the header but still..) completely borked my web site, so I had to revert to the previous version from around june 2011.

My main problem now is that you added this "wrapperElement" option which defaults to "[div /]", but there is no easy way to remove it.
I have a lot of selectmenus around my website and I don't need to add additional complexity to the markup so I wanted to disable it, but the way your code currently handles it makes it difficult to remove it.

So my question in the end is.. do you have any real testcase why this option is needed? If I want to wrap I can just wrap my [select], then when I call selectmenu() it will .insertAfter() in the right place so the result is the same... plus the it is already wrapped inside as [a][span/][span/][/a], so I really don't see any need to add an additional [div].

Also second question, do you think it's time to maintain a stable branch? With the current state I cannot afford to merge it in my production site if I have to spend several hours debugging problems each time :(

@fnagel
Copy link
Owner

fnagel commented Oct 17, 2011

It says dev version because its the dev version :-) I will always push my latest changes to the branch and release tagged version from time to time. I will release a new tagged version soon (hopefully).
If you like you could test out the new, built from scratch version which will be intergrated in jquery UI. See #140

The wrapperElement is needed as the position plugin is not able to handle a ul probably. Another use usecase is CSS scope when using different styles on the same page.

Please note: there was another issue about making Selectmenu more usable #172

@fnagel
Copy link
Owner

fnagel commented Nov 6, 2011

Any feedback on this issue?

@fnagel
Copy link
Owner

fnagel commented Nov 23, 2011

Please give feedback!

@fnagel
Copy link
Owner

fnagel commented Dec 7, 2011

Closed as no feedback was given. Please reopen if needed.

@fnagel fnagel closed this as completed Dec 7, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants