Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The computed width is different from the set width #206

Closed
oleersoy opened this issue Dec 15, 2011 · 7 comments
Closed

The computed width is different from the set width #206

oleersoy opened this issue Dec 15, 2011 · 7 comments

Comments

@oleersoy
Copy link

See:
http://jsfiddle.net/cKVB5/2/

Both the button and the selectmenu have a configured width equal to 250px. Firebug reports that the computed width of the button is 250px. The computed width of the selectmenu is 211px.

Another thing that one notices when putting a button next to a selectmenu instance is that the button will center it's content by default, but the selectmenu left aligns the selection. It would be nice if the default behavior was consistent across widgets.

@fnagel
Copy link
Owner

fnagel commented Dec 15, 2011

Your input has additional padding. Thats why its bigger. The selectmenu a tag has 250px (Firebig computed).

Mhh thats true but a native select has its text-align left. What is more important? Im pretty sure if I change this a lot people will complain that the selectmenu has centered text.

@oleersoy
Copy link
Author

AH - You are right. I played with it a little more aligning the text on the button to the left and now the form looks good.

Some extra notes, in case you know the button designer :) (Let me know if you think I should open another ticket for the button). I think the button design should be changed slightly. It should have text-align default to left and the left padding default value should be set such that text in the button and text in the selectmenu are aligned. Also it would be great if the button had a "width" property that could be set such that the button total width corresponded with the selectmenu total width.

@fnagel
Copy link
Owner

fnagel commented Dec 23, 2011

In this version of selectmenu I am the button designer, but its style is related to jQuery UI button.

Please show me an example of what you want to achieve in a new issue, I do not understand whats the reason for your proposed change.

@oleersoy
Copy link
Author

Scratch the comment. Since JQuery UI is missing input text and text area plugins, I just assumed that the button was intended to be used across the board. However I see that input text and text area components are on the 2.0 roadmap.

I started working on these plugins. I'll get them on github asap. Would love to hear what you think. I'm modifying the button plugin for this. My first two priorities are to line up content with the select menu and disable active "Flashing" when the space and enter keys are pressed. Then I'll start thinking about the disable and refresh semantics, etc. Please let me know if you have any thoughts / input.

@fnagel
Copy link
Owner

fnagel commented Dec 28, 2011

Just let me know if theres something I could take a look at.

Please note there is already a new selectmenu version in development, see #140

@oleersoy
Copy link
Author

oleersoy commented Jan 1, 2012

I just uploaded a "jquery.ui.input" (for input and textarea) plugin to a fork of this repository. I'm hoping jquery.ui will be able to use this. You can find it here:

https://github.com/oleersoy/jquery-ui/blob/selectmenu/ui/jquery.ui.input.js

And demo here:

https://github.com/oleersoy/jquery-ui/tree/selectmenu/demos/input

Thanks - I've been meaning to switch over to the #140 selectmenu. I'll start testing with that as soon as I get a beta done of the project that I'm using the current selectmenu in.

@oleersoy
Copy link
Author

oleersoy commented Jan 1, 2012

And more importantly - Happy New Year!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants