Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: enhanced event dashboard usability #540

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Fix: enhanced event dashboard usability #540

wants to merge 2 commits into from

Conversation

shwetd19
Copy link

@shwetd19 shwetd19 commented Feb 6, 2025 •
edited by sourcery-ai bot
Loading

Fixes #517

Changes:

  • Modified video configuration link to open in a new browser tab, allowing users to maintain their current dashboard context while accessing video settings
  • Removed the tickets setup tool widget from the dashboard to streamline the interface

Testing Steps:

  1. Navigate to the event dashboard
  2. Click on "Video Configuration" link - verify it opens in a new tab
  3. Verify the tickets setup tool is no longer visible on the dashboard

Note: This PR focuses on enhancing dashboard usability by implementing the requested changes while maintaining existing functionality.

Summary by Sourcery

Enhancements:

  • Improve the usability of the event dashboard.

@shwetd19
fix: enhanced event dashboard usability
ff5941f 
- Open video configuration in new tab for better UX
- Remove redundant tickets setup tool from dashboard
@sourcery-ai Sourcery AI
Copy link

sourcery-ai bot commented Feb 6, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request enhances the event dashboard usability by opening the video configuration link in a new tab and removing the tickets setup tool widget.

Flow diagram for updated dashboard interface

flowchart LR
    A[Event Dashboard] --> B{Is Video Enabled?}
    B -->|Yes| C[Video Config Link\nOpens in New Tab]
    B -->|No| D[Display Video\nDisabled Message]
    style A fill:#f9f,stroke:#333,stroke-width:2px
    style C fill:#bbf,stroke:#333,stroke-width:2px
Loading

File-Level Changes

Change Details Files
Modified video configuration link to open in a new browser tab.
  • Added target="_blank" to the video configuration link.
 src/pretix/eventyay_common/templates/eventyay_common/event/fragment_dashboard.html
Removed the tickets setup tool widget from the dashboard.
  • Removed the tickets setup tool widget.
 src/pretix/eventyay_common/templates/eventyay_common/event/fragment_dashboard.html

Assessment against linked issues

Issue Objective Addressed Explanation
#517 Open 'Video Configuration' in a new tab ✅
#517 Do not show the tickets 'Set up tool' on the eventyay common dashboard ❌ The diff does not show any changes related to removing the tickets setup tool widget from the dashboard

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Feb 6, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shwetd19 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • When opening links in a new tab with target='_blank', consider adding rel='noopener noreferrer' to mitigate potential security risks.
  • The PR description mentions removing the tickets setup tool widget, but the diff only shows the video link change. Please double-check that the widget removal is included in the changes or update the description accordingly.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟡 Security: 1 issue found
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

src/pretix/eventyay_common/templates/eventyay_common/event/fragment_dashboard.html Outdated Show resolved Hide resolved
@shwetd19
fix: added security attributes to external links
dc48baf 
- Added rel="noopener noreferrer" to video configuration link
- Prevented potential tab nabbing attacks
@mariobehling mariobehling requested a review from hongquan February 6, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@hongquan hongquan Awaiting requested review from hongquan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance event dashboard on eventyay common
1 participant
@shwetd19