Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate if get_block_hash_syscall behaves correctly #685

Closed
MaksymilianDemitraszek opened this issue Sep 19, 2023 · 1 comment · Fixed by #720
Closed

Investigate if get_block_hash_syscall behaves correctly #685

MaksymilianDemitraszek opened this issue Sep 19, 2023 · 1 comment · Fixed by #720
Assignees
@Arcticae
Labels
snforge

Comments

@MaksymilianDemitraszek
Copy link
Contributor

MaksymilianDemitraszek commented Sep 19, 2023 •
edited
Loading

Investigate if it behaves correctly in contracts deployed on cheatnet
@MaksymilianDemitraszek MaksymilianDemitraszek converted this from a draft issue Sep 19, 2023
@github-actions github-actions bot added the new label Sep 19, 2023
Closed
@Arcticae Arcticae moved this from Backlog to Triage in Starknet foundry Sep 19, 2023
@Arcticae Arcticae removed the new label Sep 19, 2023
@Arcticae Arcticae moved this from Triage to Backlog in Starknet foundry Sep 19, 2023
@Arcticae Arcticae moved this from Backlog to TODO in Starknet foundry Sep 25, 2023
@Arcticae Arcticae self-assigned this Sep 25, 2023
@Arcticae Arcticae moved this from TODO to In Progress in Starknet foundry Sep 25, 2023
@Arcticae Arcticae mentioned this issue Sep 25, 2023
Merged
5 tasks
@Arcticae
Copy link
Contributor

Related takeaway/continuation:
#721

github-merge-queue bot pushed a commit that referenced this issue Sep 27, 2023
@Arcticae
Write a test which uses get_block_hash_syscall (#720)
73f8fb2 
<!-- Reference any GitHub issues resolved by this PR -->

Closes #685 

## Introduced changes

<!-- A brief description of the changes -->

- Adds a test which verifies that this function works inside of a
contract



## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`
@github-project-automation github-project-automation bot moved this from In Progress to Done in Starknet foundry Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arcticae Arcticae

Labels
snforge
Projects
Starknet foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Write a test which uses get_block_hash_syscall foundry-rs/starknet-foundry
2 participants
@MaksymilianDemitraszek @Arcticae