Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse-portrait rotation bug #1616

Open
1 of 3 tasks
mingyee2 opened this issue Dec 18, 2024 · 11 comments
Open
1 of 3 tasks

Reverse-portrait rotation bug #1616

mingyee2 opened this issue Dec 18, 2024 · 11 comments
Labels

Comments

@mingyee2
Copy link

mingyee2 commented Dec 18, 2024

What happened?

When turning on system rotation with the “Allow reverse portrait” option off, I expect that, when I rotate my device 180 degrees slowly starting from a portrait orientation, the app orientation should enter landscape and then stay there. Instead, it enters landscape, and then re-enters portrait (but not reverse portrait) as I go to 90 rotation and then to 180 degree rotation. Notably, this only is observed if there is no currently playing video (so even with an open but paused video, this behaviour occurs).

Grayjay Version

276

What plugins are you seeing the problem on?

All

Plugin Version

No response

When do you experience the issue?

  • While logged in
  • While logged out
  • N/A

Relevant log output

No response

@Zvonimir-FUTO Zvonimir-FUTO added Bug Something isn't working Core Rotation labels Dec 18, 2024
@codebymatter
Copy link

codebymatter commented Dec 19, 2024

Looks like reverse landacape works again. Thanks so much to FUTO for fix!

Looks like reverse-portrait rotation for app is not working as of recent update. It's not a feature Ivwould use anyway, but for those that do it would affect their usability.

System Rotate is off on OS by the way. Not sure if the feature is meant to work with System Rotate enabled or if it's a bug.

@Zvonimir-FUTO
Copy link
Collaborator

Hey @codebymatter thank you for testing and reporting back. Reverse-portrait rotation is supposed to be used with system rotation so that's not a bug.

@codebymatter
Copy link

Hey @codebymatter thank you for testing and reporting back. Reverse-portrait rotation is supposed to be used with system rotation so that's not a bug.

Ah ok. Thank you for the explaination. Trsted it bc Ibwas curious about it.

@mingyee2
Copy link
Author

@Zvonimir-FUTO I just saw this was marked as fixed, but it has never appeared fixed on my end. Note that I observe this bug specifically when a video is not playing. I still see this on the most recent version (281).

@Zvonimir-FUTO
Copy link
Collaborator

Couldn't reproduce this. Could you tell me on which android version are you and which device are you using?

@mingyee2
Copy link
Author

@Zvonimir-FUTO Android 13 on Samsung A12

@kaidelorenzo
Copy link
Member

@mingyee2 can you explain again what you experience and what your settings are?

@mingyee2
Copy link
Author

@kaidelorenzo Yes, sure: turning my phone from sideways to upside down changes the app from landscape to portrait mode, but only if a video is not currently playing. I have reverse portrait disallowed, and of course screen orientation unlocked. This happens on my A12, but not on an S10 Lite I tested on.

Interestingly, I noticed similar behaviour in the Google Calendar app.

@kaidelorenzo
Copy link
Member

Ok I'm pretty sure what's going on here is that your device (A12) allows reverse portrait by default. Reverse portrait is usually not accessible on phones but that is set by the OS. I'm inclined to not make any changes to Grayjay. The intent in Grayjay is to use the system default functionality and then optionally have the allow reverse portrait setting for folks who have reverse portrait disable by default by their device OS but would like to access the orientation when using Grayjay.

Does that sounds reasonable to you? Perhaps the reverse portrait setting should be renamed to make it clear that all it does is force allow reverse portrait for devices where it is normally disabled?

@mingyee2
Copy link
Author

@kaidelorenzo No, you misunderstand: this only happens when a video is not playing. It has the desired behaviour when a video is playing. That makes no sense.

@kaidelorenzo
Copy link
Member

And it goes to portrait or reverse portrait? Like when you hold you phone upside down it displays grayjay upside down also?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants