Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing slashes on galaxy_url_prefix are no longer stripped/collapsed after upgrade to starlette 0.35.1 #17428

Open
natefoo opened this issue Feb 6, 2024 · 0 comments

Comments

@natefoo
Copy link
Member

natefoo commented Feb 6, 2024

Describe the bug
After the starlette upgrade in 0c0da9c, trailing slashes in galaxy_url_prefix are no longer stripped/collapsed/ignored as they were before. As a result, if set to /prefix/, the URL must also contain the trailing slash, e.g. http://localhost:8080/prefix//api/version or you get a 404.

Galaxy Version and/or server at which you observed the bug
Galaxy Version: 24.0 dev
Commit: 9c3a020

To Reproduce
Steps to reproduce the behavior:

  1. Set galaxy_url_prefix: /prefix/ in galaxy.yml
  2. Start galaxy and curl http://localhost:8080/prefix/api/version (fails), then curl http://localhost:8080/prefix//api/version (succeeds)
  3. Downgrade to 24b90be and pip install -r requirements.txt
  4. Start galaxy and repeat curls, both succeed.

Expected behavior
Trailing slashes are not required to be part of the URL.

Screenshots
N/A

Additional context
This was initially caught by the tests on galaxyproject/gravity#116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant