Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA Module Adds Trailing Comma to End of manifest.webmanifest #74

Open
joshasbury opened this issue Jan 3, 2025 · 1 comment
Open

Comments

@joshasbury
Copy link

Generated code looks like this:
`{
"name": "Example",
"short_name": "Example",
"lang": "en-us",
"display": "fullscreen",
"orientation" : "portrait",
"start_url": "http://localhost:1313/?utm_source=web_app_manifest",
"background_color": "#fff",
"theme_color": "#000",

}`

Note that there are also additional carriage returns following the unnecessary comma.

@tfsomrat
Copy link
Contributor

tfsomrat commented Jan 8, 2025

Thanks because you don't have a favicon for your site. Add a valid favicon source to your params.toml file. it will solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants