From d6ceb21f1fc034c9438f8def36be3b9eb3ba7db2 Mon Sep 17 00:00:00 2001 From: cpovirk Date: Wed, 15 Jan 2025 13:06:50 -0800 Subject: [PATCH] Fix automatic toolchain downloads again. Automatic toolchains downloads aren't necessary for our CI, which pre-downloads the toolchains that it needs. But automatic toolchains downloads remain necessary for local users who don't already have the necessary JDKs downloaded and registered. I had the configuration right initially, and then I broke it in cl/711746683 without noticing because (as a comment in `pom.xml` observes) you don't notice unless you clear out your local Maven configuration before running. (I still haven't done that now, as of this writing, because I'm in the process of using one of the Maven-configured JDKs for something else....) This fix also addresses this warning: ``` [WARNING] Some problems were encountered while building the effective model for com.google.guava:guava:bundle:HEAD-jre-SNAPSHOT [WARNING] 'build.pluginManagement.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.mvnsearch:toolchains-maven-plugin @ com.google.guava:guava-parent:HEAD-jre-SNAPSHOT, /usr/local/google/home/cpovirk/clients/guava-black/guava/pom.xml, line 389, column 17 [WARNING] [WARNING] Some problems were encountered while building the effective model for com.google.guava:guava-parent:pom:HEAD-jre-SNAPSHOT [WARNING] 'build.pluginManagement.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.mvnsearch:toolchains-maven-plugin @ line 389, column 17 [WARNING] [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build. [WARNING] [WARNING] For this reason, future Maven versions might no longer support building such malformed projects. ``` RELNOTES=n/a PiperOrigin-RevId: 715914892 --- android/pom.xml | 6 +----- pom.xml | 6 +----- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/android/pom.xml b/android/pom.xml index 875e84e9b9aa..9e5e3ea4f82a 100644 --- a/android/pom.xml +++ b/android/pom.xml @@ -192,6 +192,7 @@ org.mvnsearch toolchains-maven-plugin + 4.5.0