Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner: x-goog-spanner-request-id generated but not propagated in RPC to Google's Frontend server #11543

Closed
odeke-em opened this issue Jan 31, 2025 · 0 comments · Fixed by #11544
Closed

spanner: x-goog-spanner-request-id generated but not propagated in RPC to Google's Frontend server #11543

odeke-em opened this issue Jan 31, 2025 · 0 comments · Fixed by #11544
Assignees
@harshachinta
Labels
api: spanner Issues related to the Spanner API. triage me I really want to be triaged.

Comments

@odeke-em
Copy link
Contributor

Client

Spanner

Coming here to make a reference, that despite generating and testing out to ensure that x-goog-spanner-request-id is correctly generated, it wasn't being propagated to Google's Frontend server as reported to me offline.

Diagnosis

The problem is that the outgoing context isn't injected with the appropriate header in our interceptor.
@odeke-em odeke-em added the triage me I really want to be triaged. label Jan 31, 2025
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Jan 31, 2025
odeke-em added a commit to orijtech/google-cloud-go that referenced this issue Jan 31, 2025
@odeke-em
fix(spanner): inject "x-goog-spanner-request-id" into outgoing client…
4879018 
… context

Injects metadata derived from the associated gax.CallOptions that were
correctly being generated and tested, but accidentally not injected
into the outgoing context.

Fixes googleapis#11543
odeke-em added a commit to orijtech/google-cloud-go that referenced this issue Jan 31, 2025
@odeke-em
fix(spanner): inject "x-goog-spanner-request-id" into outgoing client…
281d102 
… context

Injects metadata derived from the associated gax.CallOptions that were
correctly being generated and tested, but accidentally not injected
into the outgoing context.

Fixes googleapis#11543
@odeke-em odeke-em mentioned this issue Jan 31, 2025
Merged
odeke-em added a commit to orijtech/google-cloud-go that referenced this issue Jan 31, 2025
@odeke-em
fix(spanner): inject "x-goog-spanner-request-id" into outgoing client…
acee589 
… context

Injects metadata derived from the associated gax.CallOptions that were
correctly being generated and tested, but accidentally not injected
into the outgoing context.

Fixes googleapis#11543
odeke-em added a commit to orijtech/google-cloud-go that referenced this issue Jan 31, 2025
@odeke-em
fix(spanner): inject "x-goog-spanner-request-id" into outgoing client…
bfa4afc 
… context

Injects metadata derived from the associated gax.CallOptions that were
correctly being generated and tested, but accidentally not injected
into the outgoing context.

Fixes googleapis#11543
odeke-em added a commit to orijtech/google-cloud-go that referenced this issue Jan 31, 2025
@odeke-em
fix(spanner): inject "x-goog-spanner-request-id" into outgoing client…
857012c 
… context

Injects metadata derived from the associated gax.CallOptions that were
correctly being generated and tested, but accidentally not injected
into the outgoing context.

Fixes googleapis#11543
olavloite added a commit that referenced this issue Feb 2, 2025
@odeke-em @olavloite
fix(spanner): inject "x-goog-spanner-request-id" into outgoing client…
a8f16ef 
… context (#11544)

Injects metadata derived from the associated gax.CallOptions that were
correctly being generated and tested, but accidentally not injected
into the outgoing context.

Fixes #11543

Co-authored-by: Knut Olav Løite <[email protected]>
@release-please release-please bot mentioned this issue Feb 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harshachinta harshachinta

Labels
api: spanner Issues related to the Spanner API. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
2 participants
@odeke-em @harshachinta