Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tools/spxls): preserve doc comments after formatting #1281

Merged
merged 1 commit into from
Feb 14, 2025
Merged

fix(tools/spxls): preserve doc comments after formatting #1281

merged 1 commit into from
Feb 14, 2025
+507 −70

Conversation

aofei
Copy link
Member

@aofei aofei commented Jan 27, 2025

Fixes #1269

@qiniu-prow qiniu-prow
Copy link

qiniu-prow bot commented Jan 27, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@aofei aofei requested a review from Copilot February 14, 2025 05:05
@aofei aofei marked this pull request as ready for review February 14, 2025 05:05
@qiniu-ci
Copy link

This PR has been deployed to the preview environment. You can explore it using the preview URL.

Warning

Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team.

Copilot
Copilot AI reviewed Feb 14, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
@aofei aofei requested a review from Copilot February 14, 2025 05:38
Copilot
Copilot AI reviewed Feb 14, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
@aofei aofei requested a review from Copilot February 14, 2025 06:00
Copilot
Copilot AI reviewed Feb 14, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
@nighca nighca merged commit 831ed56 into goplus:dev Feb 14, 2025
7 checks passed
@aofei aofei deleted the spxls-formatting branch February 14, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@nighca nighca nighca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preserve comment after formatting
3 participants
@aofei @qiniu-ci @nighca