-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify distributionUrl and distributionSha256Sum in gradle-wrapper.properties against the official list #286
Comments
I could get behind this feature. @eskatos what are your thoughts? |
This indeed sounds like a good idea |
@vlsi would you be willing to contribute a PR? |
I'm afraid it would take me a while (I'm not much into TypeScript) |
…detected versions - version is detected from `gradle-wrapper.properties` - checksum is only fetched for these particular versions - FIX gradle#96 While not specifically targeted, this also - RESOLVES https://github.com/gradle/wrapper-validation-action/issues/142 May enable https://github.com/gradle/wrapper-validation-action/issues/35
…detected versions - version is detected from `gradle-wrapper.properties` - checksum is only fetched for these particular versions - FIX gradle#96 While not specifically targeted, this also - RESOLVES https://github.com/gradle/wrapper-validation-action/issues/142 May enable https://github.com/gradle/wrapper-validation-action/issues/35
…detected versions - version is detected from `gradle-wrapper.properties` - checksum is only fetched for these particular versions - FIX gradle#96 While not specifically targeted, this also - RESOLVES https://github.com/gradle/wrapper-validation-action/issues/142 May enable https://github.com/gradle/wrapper-validation-action/issues/35
…detected versions - version is detected from `gradle-wrapper.properties` - checksum is only fetched for these particular versions - FIX gradle#96 While not specifically targeted, this also - RESOLVES https://github.com/gradle/wrapper-validation-action/issues/142 May enable https://github.com/gradle/wrapper-validation-action/issues/35
There appears to be an erroneous assumption that the distribution checksum is only for "official" Gradle distributions; it's merely a configurable value, alongside the also-configurable distribution URL that users can set to whatever is appropriate for them. We're using custom Gradle distributions and configuring their checksum so downloads are validated. Changing the current behaviour would break these distributions and/or reduce the security. Instead, perhaps check the distributionUrl and if its an "official" Gradle distribution then confirm that the checksum is also in the known/official list. |
Validate
gradle/wrapper/gradle-wrapper.properties
:distributionUrl
points to a canonical Gradle location. If the link is not listed in https://services.gradle.org/versions/all, then fail the validation.skip-distribution-validation: true|false
configuration option (default: false
)distributionSha256Sum
for the official distributionsThe text was updated successfully, but these errors were encountered: