Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing: maintain list of peer services => domain name #1619

Open
cedricziel opened this issue Feb 6, 2025 · 1 comment
Open

Tracing: maintain list of peer services => domain name #1619

cedricziel opened this issue Feb 6, 2025 · 1 comment

Comments

@cedricziel
Copy link

Why

In OTel, client spans can be marked with the peer.service attribute.

In the standard service graph calculation, this attribute causes a new node in the service graph to be mapped.

Example:

span:
  http.url: https://salesforce.com/foo
  peer.service: acmeforce.com

This will introduce an acmeforce.com node into the graph and calculate RED metrics towards that node. This is useful, because normally, no nodes are created and using the peer.service attribute will trigger that (similar to a handful of other attributes like db.name).

What

The proposal is to add a configuration for domain names and when encountered on spans with kind=client, http.url=$domain, add a new peer.service=$nodeName.

Illustrative example config:

peers:
  # explicit scoping could eventually address more use-cases
  domains:
    nodeName: ^force.com$
@grcevski
Copy link
Contributor

grcevski commented Feb 6, 2025

Good proposal! Just to clarify, the feature request is not simply to derive peer.service based on the domain in http.url, it should also allow for substitutions based on defined rules. If it just adding the peer.service attribute it's very easy for us to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants