Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to query profiles by span ID #338

Open
simonswine opened this issue Jan 21, 2025 · 0 comments
Open

Add ability to query profiles by span ID #338

simonswine opened this issue Jan 21, 2025 · 0 comments

Comments

@simonswine
Copy link
Contributor

Feature description

Is your feature request related to a problem? Please describe.

Currently in order to view trace profiles, it is required to use the "Classic Explore -> Pyroscope" view. Under query options it allows to filter by a known span id. Otherwise there is not mechanism to discover span id, they will almost likely always come from a deeplink out of the "Classic Explore -> Traces" view.

View in "Classic Explore -> Pyroscope":

Image

Source of the link:

Image

This is how the link looks like decoded:

https://sedemo.grafana.net/explore?left={"range":{"from":"1737449192564","to":"1737449313765"},"datasource":"grafanacloud-profiles","queries":[{"labelSelector":"{service_name=\"pyroscope-rideshare-go\"}","groupBy":[],"profileTypeId":"process_cpu:cpu:nanoseconds:cpu:nanoseconds","queryType":"profile","spanSelector":["7f80395fd15dcdc9"],"refId":"profile"}]}

Describe the solution you'd like

I would like to replace the Classic Explore fully with "Explore Profiles" and there for being able to filter profiles by span ID. It would also nice, if the Explore Profiles could list traces involved by the profile on show. (Backend feature is tracked in grafana/pyroscope#3289)

Alternatives considered

Describe alternatives you've considered

  • We could just stay with Classic Explore for longer

Additional context

Related

@grafakus grafakus changed the title [feature] Add ability to query profiles by span ID Add ability to query profiles by span ID Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants