Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flamegraph] Visualize when there's inlining happening between two nodes in a flamegraph #350

Open
simonswine opened this issue Jan 24, 2025 · 0 comments
Labels

Comments

@simonswine
Copy link
Contributor

Feature description

Is your feature request related to a problem? Please describe.

When one or more functions are inlined into its caller, the upstream flamegraph of pprof shows this by not displaying a border between two nodes:

Image

So in this example:

  • (*Mutex).Unlock inlined into (*RWMutex).Unlock
  • (*Mutex).Lock inlined into(*RWMutex).Lock

We currently show this like this:

Image

Describe the solution you'd like

I think we should consider following the example of pprof

@grafakus grafakus added the enhancement New feature or request label Jan 24, 2025
@grafakus grafakus changed the title [feature] Visualize when there's inlining happening between two nodes in a flamegraph Visualize when there's inlining happening between two nodes in a flamegraph Jan 24, 2025
@grafakus grafakus changed the title Visualize when there's inlining happening between two nodes in a flamegraph [flamegraph] Visualize when there's inlining happening between two nodes in a flamegraph Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants