Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation feedback: /docs/sources/mimir/visualize/native-histograms/_index.md #10401

Open
ccronemberger opened this issue Jan 10, 2025 · 4 comments

Comments

@ccronemberger
Copy link

For the histogram_count description I think it would be helpful to mention that the count is cumulative.

@dimitarvdimitrov
Copy link
Contributor

@krajorama @tacole02 can you guys take a look at this one?

@tacole02
Copy link
Contributor

I can add a note to https://grafana.com/docs/mimir/latest/visualize/native-histograms/#query-your-histograms-count-or-sum stating that the count is cumulative. What do you think, @krajorama ?

@krajorama
Copy link
Contributor

Hi,

I don't quite understand the comment.

In what sense would you say the count is cumulative ?

If we look at the count compared to individual buckets in a single native histogram, it is true that the count is a sum of all individual bucket counts - as stated in the documentation - but I wouldn't say "cumulative" because that could be confused with something else.

If we look at it from a time series perspective, the count may or may not be cumulative. Currently programs will emit native histograms that count observations over time - so cumulative. However you can write a recording rule to record the rate of such native histograms, in which case the resulting native histogram will store rate values , which are not cumulative.

The function histogram_count works the same on cumulative and non-cumulative (i.e. gauge) native histograms, it just returns the count value.

I feel this is beyond the scope of our documentation, but what we could do is to reference the new specification document that @beorn7 wrote recently: https://prometheus.io/docs/specs/native_histograms/. The document does mention the above flavors: https://prometheus.io/docs/specs/native_histograms/#flavors.

@tacole02
Copy link
Contributor

I think this is a really good idea, @krajorama . Adding a link to the spec could provide more useful context overall. Let me know if this is how you'd like to proceed, and I can make the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants