List line breaks should ignore the list prefix

[HamousOnWheels]

⚠️ This issue respects the following points: ⚠️

• This is a bug. Not a question or feature request.
• The topic is not already reported at Issues. (I've searched it).
• Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
• The bug is still present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor settings are not touched. In case the issue is resolved there, you don't need to create a bug report. The change will be part of the next Markor update.)

Description

with wrapping turned on, long lines in a list will break at the list prefix (dash or number) if they don't have any spaces to break at. this leaves gaps in the list. this happens with for example, long links or hashes

i think the wrapping logic should skip the list prefix. example of how obsidian and vscode respectively do it:

this doesn't happen in preview mode, only the editor. mainly interested in markdown, but this seems to happen with any text format

Steps to reproduce

1. paste one or more lines , longer than the screen width, in an unordered or ordered list
2. turn on line wrapping

Information

Android version: 11
Device: motorola moto g8 power
App Version: 2.14

Source

F-Droid

Format / File type

Not specific

Additional info / Log

-

[gsantner]

Unlikely feasible with the way how Android standard EditText component is implemented.

[harshad1]

We can play around with line breaking strategy a little. https://developer.android.com/reference/kotlin/androidx/compose/ui/text/style/LineBreak.Strategy

[harshad1]

I have spent a significant amount of time investigating this and I can't find a way to improve this without incurring a bad performance hit

[harshad1]

Setting

            android:breakStrategy="balanced" (or high_quality)
            android:hyphenationFrequency="normalFast"

Helps a lot but can

1. cause some layout performance slowdowns according to documentation
2. will cause broken words to have a hyphen inserted at the break (sometimes)

[harshad1]

@gsantner We can

1. switch
2. do nothing
3. Make it an option
4. Add a heuristic to change settings for very long files

IMO we switch and see if anyone complains :)

[gsantner]

Suggestion: There is a function named like isPerformanceDevice in AppSettings to make a certain differenciation.

Do suggest to apply the more complex rule by that condition, fixed

[harshad1]

ContextUtils.isDeviceGoodHardware :)

After some more testing I have decided not to make a PR with this change. The docs say that the 'simple' break strategy is used to prevent text 'jumping' as one types. This does seem to happen more with 'balanced' or 'high quality'. Overall I think appearance is less important than performance in edit mode.

I feel like I spend 50% of my Markor development / hobby time fighting with Android's TextView / EditText. So many bad decisions in it's design...

[gsantner]

Totally agree, it's just not made for many things.

However, it works good enough for majority of things :-).

Thanks