Should the methods match? #1188
-
|
Should the methods in these two classes match? abqpy/src/abaqus/XY/XYSession.py Line 20 in 16ed3e4 Line 14 in 16ed3e4 If so, some type annotations needs to be corrected and the docstrings may be modified. I'm not sure if it is necessary to add implementation on I mean, not all the methods, but only the ones with same name and signature. |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 2 replies
-
|
Yes, I think it should match. But I think there are some issues in the current code, method like XYData.. in XYSession should not be staticmethods and methods like XYDataFrom in XYData should be staticmethods. |
Beta Was this translation helpful? Give feedback.
-
|
@haiiliin There is also a missing method Should it be add to |
Beta Was this translation helpful? Give feedback.
-
|
Yes, I think so, somehow it is missed. |
Beta Was this translation helpful? Give feedback.
-
|
Done on be45282 |
Beta Was this translation helpful? Give feedback.
Yes, I think it should match. But I think there are some issues in the current code, method like XYData.. in XYSession should not be staticmethods and methods like XYDataFrom in XYData should be staticmethods.