Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of fallible-iterator as a direct dependency, import from postgres #12

Open
jacobsvante opened this issue Jan 10, 2025 · 3 comments

Comments

@jacobsvante
Copy link
Collaborator

This is the only outdated dependency we have. The postgres crate exports fallible_iterator, which we could use.

@beanpuppy
Copy link

tokio-postgres doesn't appear to re-export it however: https://docs.rs/tokio-postgres/latest/tokio_postgres/#reexports. If we were to use the re-exported fallible_iterator for the sync postgres only we'd need to have two types of imports in the codegen, which I don't really think is worth doing.

@beanpuppy
Copy link

I also see both packages use fallible-iterator = "0.2" in their Cargo.toml. I suggest we follow suit if we want it to stay updated.

@jacobsvante
Copy link
Collaborator Author

Correct, the postgres crate publically exports fallible_iterator and tokio-postgres does not.

However, postgres is just a thin wrapper around tokio-postgres, so I'm thinking that maybe we can include both crates, always?

If we then always follow the fallible-iterator version that postgres exports, we don't have to worry about being out of sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants