Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more themes for the error screen #11

Open
haroldadmin opened this issue Sep 15, 2020 · 2 comments
Open

Add more themes for the error screen #11

haroldadmin opened this issue Sep 15, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@haroldadmin
Copy link
Owner

The current error reporting screen supports both light and dark themes, using the Material Components library. It would be great if we could provide more customization options to the user in the form of additional themes.

Tasks:

  • Add additional themes to styles.xml
  • Make themes configurable through application code, or manifest merger (needs exploration)
  • Perform a check in WhatTheStackActivity to decide which theme to use
@haroldadmin haroldadmin added enhancement New feature or request good first issue Good for newcomers Hacktoberfest labels Sep 15, 2020
@rohitjakhar
Copy link

Hey @haroldadmin, assign this issue to me. I would be doing this as part of hacktoberfest, so I would raise a PR on or after 1st October 2020.

@haroldadmin
Copy link
Owner Author

Before we do that, it would be great to know how you plan to approach these changes.

Would you be able to share details such as:

  1. What themes do you want to add?
  2. How do you plan on making the themes configurable by the consumers of the library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants