Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a broken link #36102

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Remove a broken link #36102

merged 2 commits into from
Dec 3, 2024

Conversation

hiroakis
Copy link
Contributor

This Pull Request removes a broken link from the CopyFile function located in internal/copy/copy_file.go. The removed comment referenced an external gist URL that is no longer accessible.

The comment itself provides sufficient context to understand the code without the link, so I believe it is better to remove it.

@hiroakis hiroakis requested a review from a team as a code owner November 26, 2024 12:24
Copy link

hashicorp-cla-app bot commented Nov 26, 2024

CLA assistant check
All committers have signed the CLA.

@crw crw added the enhancement label Dec 2, 2024
@crw
Copy link
Contributor

crw commented Dec 2, 2024

Thanks for this contribution! The team does not normally accept changes to documentation without other work being done in the file, however, I will raise this in triage. Thanks again!

@liamcervante liamcervante merged commit 017c8d2 into hashicorp:main Dec 3, 2024
7 checks passed
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants