Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapter stopped connecting to hipchat #307

Closed
dfraser opened this issue Jun 14, 2018 · 11 comments
Closed

Adapter stopped connecting to hipchat #307

dfraser opened this issue Jun 14, 2018 · 11 comments

Comments

@dfraser
Copy link

dfraser commented Jun 14, 2018

This adapter was working perfectly for me for years... Now it won't connect at all. Perhaps Hipchat somehow broke compatibility. I've tried resetting the password for the Hipchat account I used, doing an npm update, updating packages on the host computer... no luck.

Here are the logs:

Jun 14 15:57:41 hubot systemd[1]: Starting Hubot...
[Thu Jun 14 2018 15:57:45 GMT-0400 (EDT)] DEBUG Loading adapter hipchat
[Thu Jun 14 2018 15:57:46 GMT-0400 (EDT)] DEBUG HipChat adapter options: {"jid":"[email protected]","password":"xxxxx","token":null,"rooms":"All","rooms_blacklist":"","host":null,"bosh":{"url":null},"autojoin":false,"xmppDomain":null,"reconnect":true}
[Thu Jun 14 2018 15:57:46 GMT-0400 (EDT)] INFO Connecting HipChat adapter...
[Thu Jun 14 2018 15:59:54 GMT-0400 (EDT)] DEBUG Disconnecting here
[Thu Jun 14 2018 15:59:54 GMT-0400 (EDT)] INFO Connection went offline
....

Here is my package.json:

{
  "name": "testbot",
  "version": "0.0.0",
  "private": true,
  "author": "",
  "description": "Test bot",
  "dependencies": {
    "amqplib": "0.5.1",
    "hubot": "^2.19.0",
    "hubot-diagnostics": "0.0.1",
    "hubot-google-images": "^0.2.6",
    "hubot-google-translate": "^0.2.0",
    "hubot-help": "^1.0.1",
    "hubot-heroku-keepalive": "^1.0.2",
    "hubot-hipchat": "^2.12.0-6",
    "hubot-maps": "0.0.2",
    "hubot-pugme": "^0.1.0",
    "hubot-redis-brain": "0.0.3",
    "hubot-rules": "^0.1.1",
    "hubot-scripts": "^2.17.2",
    "hubot-shipit": "^0.2.0",
    "sprintf-js": "^1.0.3",
    "thumbor": "^0.1.3",
    "xml2js": "^0.4.17"
  },
  "engines": {
    "node": "0.10.x"
  }
}

@OrganicPanda
Copy link

Same here, hope it starts working again soon

@rwinikates
Copy link

Also having similar issues with our connection.

@bringink
Copy link

I met the same issue. And I found following Workaround for Atlassian Server platform.
https://confluence.atlassian.com/hipchatkb/hubot-stopped-working-on-hipchat-server-v2-0-7-and-later-867181545.html
https://confluence.atlassian.com/hipchatkb/external-xmpp-ports-5222-5223-disabled-by-default-in-hipchat-server-2-0-7-859442760.html

Unfortunately my hipchat is using Atlassian Cloud which I couldn't find any workaround for cloud so far.

@dangerbell
Copy link

Same issue here. Sometimes it claims to reconnect successfully, but I'm never able to use robot.messageRoom() to send a message. It always gives me this error:

2018-06-19T22:40:25.296953+00:00 app[web.1]: [Tue Jun 19 2018 22:40:25 GMT+0000 (Coordinated Universal Time)] ERROR TypeError: Cannot read property 'message' of undefined
2018-06-19T22:40:25.296957+00:00 app[web.1]: at Robot.HipChat.send (/app/node_modules/hubot-hipchat/src/hipchat.coffee:35:7, <js>:50:38)
2018-06-19T22:40:25.296959+00:00 app[web.1]: at Robot.messageRoom (/app/node_modules/hubot/src/robot.js:608:23)
2018-06-19T22:40:25.296960+00:00 app[web.1]: at /app/scripts/github-workflow.coffee:157:70, <js>:111:14
2018-06-19T22:40:25.296962+00:00 app[web.1]: at Object.callback (/app/node_modules/githubot/lib/githubot.js:113:20)
2018-06-19T22:40:25.296963+00:00 app[web.1]: at next (/app/node_modules/async/lib/async.js:723:43)
2018-06-19T22:40:25.296965+00:00 app[web.1]: at /app/node_modules/async/lib/async.js:24:16
2018-06-19T22:40:25.296967+00:00 app[web.1]: at IncomingMessage.<anonymous> (/app/node_modules/scoped-http-client/src/index.js:95:22)
2018-06-19T22:40:25.296968+00:00 app[web.1]: at IncomingMessage.emit (events.js:187:15)
2018-06-19T22:40:25.296970+00:00 app[web.1]: at endReadableNT (_stream_readable.js:1081:12)
2018-06-19T22:40:25.296971+00:00 app[web.1]: at process._tickCallback (internal/process/next_tick.js:63:19)

(github-workflow.coffee is our custom code.)

Oddly enough plugins we didn't write still seem to work. But I can't see a difference between how they're created.

@andrewmeissner
Copy link

Same issue here. :(

@mwarkentin
Copy link

We are seeing the same - get hundreds of "connection offline" logs when restarting the hubot process.

@slepp
Copy link

slepp commented Jun 20, 2018

I found that by using both the master branch of this repo (instead of the 2.12.0-6 release version) and changing the hipchat.coffee send method, it seems to be back to normal now. The repeated connection offline output is cleaned up in this master, but the messageRoom method was still broken afterward.

The commit is slepp@126f875

I've pushed the little change to my own repo: https://github.com/slepp/hubot-hipchat

@rberrelleza
Copy link
Contributor

@slepp if that fixes the issue, could you send a PR? I can merge and release a new version later today.

@slepp
Copy link

slepp commented Jun 20, 2018

This may be fixed partly by #308 and #304, those two combined fixed things for us.

@dfraser
Copy link
Author

dfraser commented Oct 15, 2018

Solved by migrating team to Slack :|

@dfraser dfraser closed this as completed Oct 15, 2018
@andrewmeissner
Copy link

same...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants