Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is sf a package suggestion for modules? #41

Open
tmelliott opened this issue Aug 29, 2018 · 2 comments
Open

Why is sf a package suggestion for modules? #41

tmelliott opened this issue Aug 29, 2018 · 2 comments
Assignees

Comments

@tmelliott
Copy link
Member

This will cause some issues as it uses requireNamespace('sf') without being inside an if.

Ideally, anything requiring sf should instead access functions inside iNZightMaps which can do the bulk of the work.

This is probably a significant amount of work, so I wont adjust it now (and instead manually remove sf from the build).

@daniel-barnett
Copy link
Contributor

This is to allow the whole preview thing while choosing maps (I think...). I should be able to refactor that into a function in maps to eliminate the dependency

@tmelliott
Copy link
Member Author

That would be great. Ideally the Modules GUI just calls functions inside the other package, which is especially useful for replicating on Lite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants