-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ISEB is not included in buildingCatalogue.ts #1085
Comments
Hi could I take this |
Reopening Issue -- we should be updating our catalogue via our scraper, not manually |
Where would we scrape it from, though? |
This issue should be closed, and the scraping option, if feasible, should be a new issue. This is just the "good first task" bug |
On mobile, but we have a scraper that hits https://map.uci.edu |
Im fully aware that I'm being rather pedantic about this, but this issue hasn't really been resolved properly -- we don't manually insert location entries. I'd rather not revert the PR, but the issue frankly was not resolved appropriately (which is my fault as I did a poor issue write up) |
The scraper is already implemented, and just needs to be run. We shouldn't be manually inserting. |
We sourced our data in
buildingCatalogue.ts
from https://classrooms.uci.edu/classrooms/, but their directory doesn't include ISEB. There are indeed courses hosted in ISEB (although few), and it's a popular spot to study/have events, so custom events may want to use ISEB as a location.We should add ISEB to our list; whether we manually create that data point or find a new, more comprehensive list can be at the PR's discretionImplementation
Relevant Files
apps/antalmanac/tools/catalogue_builder.js
which scrapeshttps://map.uci.edu
for all of the locations currently available.apps/antalmanac/src/lib/buildingCatalogue.ts
which is a mapping of IDs to locations/Users/kevinwu/Documents/Code/ICSSC/AntAlmanac/apps/antalmanac/src/components/RightPane/SectionTable/static/locations.json
which is a mapping of locations to IDs.Your Task
apps/antalmanac/src/lib
, maybe name itlocations
catalogue_builder
to be camelCased, in Typescript, AND to build bothbuildingCatalogue
andlocations.json
at the same time.locations.test.ts
should pass. There should be no need to edit this file, but you're free to if it serves a purpose.From user feedback:
The text was updated successfully, but these errors were encountered: