Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a "Professor not found" to search results #282

Closed
nathantoannguyen opened this issue Apr 21, 2023 · 1 comment · Fixed by #297
Closed

Add a "Professor not found" to search results #282

nathantoannguyen opened this issue Apr 21, 2023 · 1 comment · Fixed by #297
Assignees
@MFYLM @nathantoannguyen
Labels
frontend Front End tasks mvp resolve this to include task in PeterPortal MVP and move out of beta testing Story Point: 3 backend or full-stack change. maybe adding an endpoint or changing the response of an endpoint + the

Comments

@nathantoannguyen
Copy link
Contributor

Add a Professor not found image/text when the search cannot find any courses that match the search.

Similar to Issue #271
@nathantoannguyen nathantoannguyen added frontend Front End tasks Story Point: 3 backend or full-stack change. maybe adding an endpoint or changing the response of an endpoint + the mvp resolve this to include task in PeterPortal MVP and move out of beta testing labels Apr 21, 2023
@MFYLM MFYLM self-assigned this May 16, 2023
@ethanwong16
Copy link
Member

For now on the UI, just use a simple course card shape to display the text / emoji "No results found :( "

Same goes for issue #271

@js0mmer js0mmer linked a pull request Feb 12, 2024 that will close this issue
Implement Search Pagination #297
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MFYLM MFYLM

@nathantoannguyen nathantoannguyen

Labels
frontend Front End tasks mvp resolve this to include task in PeterPortal MVP and move out of beta testing Story Point: 3 backend or full-stack change. maybe adding an endpoint or changing the response of an endpoint + the
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Search Pagination icssc/peterportal-client
3 participants
@ethanwong16 @MFYLM @nathantoannguyen