-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pagination Performance Improvement #310
Comments
I think this might be more related to websoc-fuzzy-search, given that we call that first on the frontend, get the list of courseIds, and request information for those specific courses from PPAPI through our backend. |
Potential improvement: only get websoc-fuzzy-search results for a window of 3-5 pages at a time. Limiting results speeds up response time of websoc-fuzzy-search greatly. The problem is, we can not specify offset for websoc-fuzzy-search. This means we would have to load all the results up to the current page plus the 2 after. Being able to specify an offset may allow for faster response times but I'm not entirely sure since I don't know the implementation details. It may be just as slow as loading everything up to that page plus the 2 pages after so we should try that first. An alternative, possibly simpler improvement: load first 5 pages of fuzzy search initially and render the page, load the rest in the background so it's ready by the time the user clicks one of the pagination buttons. |
search overhauled in #505 |
Currently, the new pagination feature requests all results from PPAPI, which might be inefficient, as there are around 6000 records for courses. PPAPI endpoint does not support range queries for now. Therefore, the temporary solution, before the feature is implemented, will be to request only the first few pages, and then request more only when users reach the end of the list.
The text was updated successfully, but these errors were encountered: