Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to only create applied_migrations table as Pillar 3.3.0 does. #13

Open
manuelkiessling opened this issue Sep 15, 2016 · 3 comments

Comments

@manuelkiessling
Copy link
Contributor

I'm going to send a PR for this.

@magro
Copy link
Member

magro commented Sep 15, 2016

Sounds good! :-)

@manuelkiessling
Copy link
Contributor Author

manuelkiessling commented Sep 15, 2016

Yes, but of course there is a hook attached :-)

Please see Galeria-Kaufhof@d7172c3

This doesn't compile because ReplicationOptions is history in Pillar 3.3.0. Getting to the correct ReplicationStrategy is much more involved now, and it seems like we'd have to extend sbt-pillar-plugin's config scheme in order to honor complex NetworkTopologyStrategy configs.

Do you see a simple solution?

@magro
Copy link
Member

magro commented Sep 15, 2016

So the question is how to allow the user to configure the ReplicationStrategy? I'd go for s.th. like what com.datastax.driver.core.ReplicationStrategy#create or com.datastax.driver.core.KeyspaceMetadata#build does. E.g. the user could specify

cassandra.replicationStrategy = "'class' : 'NetworkTopologyStrategy', 'dc1' : 3, 'dc2' : 2"

or

cassandra.replicationStrategy = "'class' : 'SimpleStrategy', 'replication_factor' : 3"

This should be fairly intuitive as it's quite close to the CQL documentation.

We could still keep support for cassandra.replicationFactor to override / set the replication factor if needed.

WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants