[#501] Open external links safely in new tab #606
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution based on search result style. Closes italia#271
Support for SVG logo for GitHub
* Add check on enabling platforms
Expand the interactive area in search results.
Bumps [parallel](https://github.com/grosser/parallel) from 1.17.0 to 1.19.0. - [Release notes](https://github.com/grosser/parallel/releases) - [Commits](grosser/parallel@v1.17.0...v1.19.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
…-1.19.0 Bump parallel from 1.17.0 to 1.19.0
|
Hello @MasihTak, can you rebase this one on master please? |
Or if you need assistance feel free to ask for it :) |
|
Hello @bfabio I pushed changes with the Atom and it mess up |
bfabio
reviewed
Sep 1, 2020
There was a problem hiding this comment.
I'm not sure we want noreferrer for .italia.it sites. @libremente WDYT?
Yes, we don't want it. Could you please correct it @MasihTak? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As already mentioned in #ISSUE_NUMBER, this PR tackles:
Open external links in new tab with security to prevent tabnapping and other phishing attacks.
This PR does not cover 100% of external links! I need to spend more time fixing others including the documentation links.
Checklist
Fixes