Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for published jwt-vc-issuer endpoint #333

Open
Zicchio opened this issue Jan 27, 2025 · 0 comments
Open

Drop support for published jwt-vc-issuer endpoint #333

Zicchio opened this issue Jan 27, 2025 · 0 comments

Comments

@Zicchio
Copy link
Collaborator

Zicchio commented Jan 27, 2025

PR #328 added the possibility to publish metadata endpoints, with /.well-known/jwt-vc-issuer and /.well-known/jar-issuer used as default example.
However, it appears that the endpoint /.well-known/jwt-vc-issuer should not be published as it might be reserved to issuers of verifiable credentials, which we are not.

One possible quick solution is to let DirectTrustSdJwtVc ovveride the method

def build_metadata_endpoints(self, backend_name: str, entity_uri: str) -> list[tuple[str, Callable[[satosa.context.Context, Any], satosa.response.Response]]]:
if not self.jwk_endpoint:
return []
metadata_path = '^' + self._build_metadata_path(backend_name) + '$'
response_json = self._build_metadata_with_issuer_jwk(entity_uri)
def metadata_response_fn(ctx: satosa.context.Context, *args) -> satosa.response.Response:
return JsonResponse(message=response_json)
return [(metadata_path, metadata_response_fn)]

with a simple return []

@Zicchio Zicchio added the trust label Jan 27, 2025
@peppelinux peppelinux added this to the 1.1.0 milestone Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants