Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Satosa] Review exception at HTTP handler level to minimize information disclosure. #339

Open
Zicchio opened this issue Jan 27, 2025 · 0 comments
Labels
code-quality enhancement Something improving existing features security
Milestone

Comments

@Zicchio
Copy link
Collaborator

Zicchio commented Jan 27, 2025

In the project, not enough care is dedicated in the exception management of the satosa HTTP handlers.
Sometimes we have good exceptions like this

self._handle_401(context, "invalid authentication method: token might be invalid or expired", e401)

and sometimes we have approximative error management like this one
return self._handle_400(context, e400.args[0], HTTPError(e400.args[0]))

The biggest risk is that we indvertitedly might induce information disclure by telling the user detailed exceptions or error messages . In particular, observe that:

@peppelinux peppelinux added the enhancement Something improving existing features label Jan 27, 2025
@peppelinux peppelinux added this to the 1.0.0 milestone Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality enhancement Something improving existing features security
Projects
Status: Todo
Development

No branches or pull requests

2 participants