Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't search beyond currently loaded chunk? #20

Closed
moshee opened this issue Oct 23, 2018 · 2 comments
Closed

Can't search beyond currently loaded chunk? #20

moshee opened this issue Oct 23, 2018 · 2 comments

Comments

@moshee
Copy link

moshee commented Oct 23, 2018

When using the search (/) command I can't seem to get results for any strings that aren't already visible on the screen. If I scroll down to where a string becomes visible, then hitting 'n' will then jump to it, but if it's not on the screen, 'n' will do nothing. Is this correct?

@moshee moshee changed the title Can't search more than 2-long string Can't search beyond currently loaded chunk? Oct 23, 2018
@itchyny
Copy link
Owner

itchyny commented Oct 25, 2018

Yes, I agree it's not a good behavior. I'm thinking of implementing a asynchronous search as listed in #1, not to block the user's cursor motion. Create a new goroutine to search around the file and feedback to the main goroutine when the text is found.

@itchyny
Copy link
Owner

itchyny commented Jan 22, 2019

This is implemented in ccab6b8.

@itchyny itchyny reopened this Jan 22, 2019
@itchyny itchyny closed this as completed Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants