Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cookies are saved only for session #34

Open
adeelhussain opened this issue Oct 11, 2014 · 2 comments
Open

cookies are saved only for session #34

adeelhussain opened this issue Oct 11, 2014 · 2 comments

Comments

@adeelhussain
Copy link

cookies are saved only for session not a particular time, when set any date or time in options object ,it creates invalid date

@chriskuhar
Copy link

reading the code, there seems Date(), Date.setDate and Date.getDate are not used correctly. They get / set the day of the month, and the code just slams in the number sent in for expires plus now(). Momentjs or similar a similar date package needs to be used for date math to properly formulate the date. setDate() fails if the value exceeds the calendar numerical day.

@holsted
Copy link

holsted commented Oct 6, 2015

Seeing an issue as well with expiry dates not working properly and the cookie just being set for the session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants