Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color contrast test incorrect on some font sizes #116

Open
timmhayes opened this issue Apr 28, 2017 · 2 comments
Open

Color contrast test incorrect on some font sizes #116

timmhayes opened this issue Apr 28, 2017 · 2 comments

Comments

@timmhayes
Copy link

The color contrast tool does not work correctly on fonts that are sized with decimals. I've seen this fail in Chrome with an element that had a size of 10pt, which was rendered at 13.3333px and showed up as a large font that only needs to have a 3.0 contrast ratio.

See a sample of this here:
http://output.jsbin.com/vutotup

I looked through your code and found the issue, but it is a problem in the axs.utils.isLargeFont function of the GoogleChome accessibility-developer-tools. So opened this issue for you:
GoogleChrome/accessibility-developer-tools#345

and created this pull request:
GoogleChrome/accessibility-developer-tools#346

I hope it works out for you, since I really like the tool. Thanks!

@mlp73
Copy link

mlp73 commented Jan 30, 2018

Same issue here. The extension is throwing "low contrast ratio" fail on fonts which are compiled over 24px and pass the accepted contrast ratio.

@timmhayes
Copy link
Author

My pull request on Google's accessibility-developer-tools has sat unmerged for the last 9 months, so I simply made the change in my local version of tota11y. You can see the unminified changes in Google's repository. I hope that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants