Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Servlet error pages do not work when Response.writeError is called before entering the ServletChannel #12697

Open
lachlan-roberts opened this issue Jan 10, 2025 · 0 comments
Open

Servlet error pages do not work when Response.writeError is called before entering the ServletChannel #12697

lachlan-roberts opened this issue Jan 10, 2025 · 0 comments
Assignees
@lachlan-roberts
Labels
Bug For general bugs on Jetty side

Comments

@lachlan-roberts
Copy link
Contributor

Jetty version(s)
12.0.x, 12.1.x

Description

From places like Authenticators the Response.writeError() may be called before the request has entered the ServletChannel.

This will end up in the servlet ErrorHandler which may dispatch to a servlet, but it is not running in the ServletChannel so this does not work as intended.
@lachlan-roberts lachlan-roberts added the Bug For general bugs on Jetty side label Jan 10, 2025
@lachlan-roberts lachlan-roberts self-assigned this Jan 10, 2025
lachlan-roberts added a commit that referenced this issue Jan 10, 2025
@lachlan-roberts
Issue #12697 - do not dispatch to error page outside of ServletChannel
65495d7 
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue Jan 10, 2025
@lachlan-roberts
Issue #12697 - resolve use of Response.writeError in authenticators
7f31cb4 
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue Jan 10, 2025
@lachlan-roberts
Issue #12697 - improve testing for FormAuthenticatorTest
cf504e5 
Signed-off-by: Lachlan Roberts <[email protected]>
@lachlan-roberts lachlan-roberts mentioned this issue Jan 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lachlan-roberts