Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config schema raises an error when using a list for ui.editor #5617

Open
heygarrett opened this issue Feb 7, 2025 · 1 comment
Open

config schema raises an error when using a list for ui.editor #5617

heygarrett opened this issue Feb 7, 2025 · 1 comment
Labels
🐛bug Something isn't working

Comments

@heygarrett
Copy link

Description

As a workaround to #3753 I've configured ui.editor using a list of strings:

[ui]
editor = ["nvim", "--cmd", "let g:launched_by_shell=1"]

But after adding the schema to the top of the config file:

"$schema" = "https://jj-vcs.github.io/jj/latest/config-schema.json"

Taplo raises an error on the editor property:

Even Better TOML: ["nvim","--cmd","let g:launched_by_shell=1"] is not of type "string"

Specifications

  • Platform: macOS 15.3
  • Version: jj 0.26.0
@ilyagr ilyagr added the 🐛bug Something isn't working label Feb 7, 2025
@dnaka91
Copy link

dnaka91 commented Feb 7, 2025

Same here. Also, similar issue with the ui.diff.tool setting (which I see as the same issue because both settings are described in the docs to either take a string or array):

[ui.diff]
tool = ["difft", "--color=always", "$left", "$right"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants