From 6a88b08feb36df51b411a9aaec53810f1dc726ff Mon Sep 17 00:00:00 2001
From: Josh Choo <dev@joshuous.com>
Date: Sat, 26 Jan 2019 12:22:12 +0800
Subject: [PATCH] refactor(MissingBlobs): Track missing dependencies using a
 Set

The missingBlobs Map object's value was never used and always
remained null. Switching to a Set improves clarity.
---
 src/MissingBlobs.java | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/MissingBlobs.java b/src/MissingBlobs.java
index 8dd36bb..2a8d15a 100644
--- a/src/MissingBlobs.java
+++ b/src/MissingBlobs.java
@@ -3,7 +3,9 @@
 import java.io.InputStreamReader;
 import java.util.ArrayList;
 import java.util.HashMap;
+import java.util.HashSet;
 import java.util.Map;
+import java.util.Set;
 
 public class MissingBlobs {
 
@@ -20,10 +22,9 @@ public class MissingBlobs {
 	private HashMap<String, ArrayList<Blob>> dependencyBlobs;
 
 	/*
-	 * Key: Name of missing blob dependency
-	 * Value: Null (unused)
+	 * Value: Name of missing blob dependency
 	 */
-	private HashMap<String, String> missingBlobs;
+	private Set<String> missingBlobs;
 
 	private String expandArrayList(ArrayList<Blob> arr) {
 		StringBuilder expanded = new StringBuilder();
@@ -103,21 +104,20 @@ public void addBlobDir(String blobPath) {
 	}
 
 	public void updateMissingBlobs() {
-		missingBlobs = new HashMap<String, String>();
+		missingBlobs = new HashSet<String>();
 
 		for (Map.Entry<String, ArrayList<Blob>> blob : dependencyBlobs.entrySet()) {
 			String dependencyName = blob.getKey();
 
-			if (missingBlobs.containsKey(dependencyName) || presentBlobs.containsKey(dependencyName))
+			if (missingBlobs.contains(dependencyName) || presentBlobs.containsKey(dependencyName))
 				continue;
 
-			missingBlobs.put(dependencyName, null);
+			missingBlobs.add(dependencyName);
 		}
 	}
 
 	public void showMissingBlobs() {
-		for (Map.Entry<String, String> blob : missingBlobs.entrySet()) {
-			String dependencyName = blob.getKey();
+		for (String dependencyName : missingBlobs) {
 			ArrayList<Blob> blobsWithDependencies = dependencyBlobs.get(dependencyName);
 			System.out.println(dependencyName + " required by: " + expandArrayList(blobsWithDependencies));
 		}