Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: using Fast Positive Hash as a hash function #16

Open
data-man opened this issue Mar 6, 2018 · 3 comments
Open

Feature request: using Fast Positive Hash as a hash function #16

data-man opened this issue Mar 6, 2018 · 3 comments
Assignees

Comments

@data-man
Copy link

data-man commented Mar 6, 2018

t1ha - one of the fastest hash functions I know.
The author of the library has a fork the jdupes. Very fast.
It would be great if the dupd would use this library (optionally).

@jvirkki
Copy link
Owner

jvirkki commented Mar 6, 2018

Thanks for the pointer, I'll give it a try.

I don't want to make it a hard dependency because I'm trying to keep dupd free of all external dependencies so it is easy for everyone to build. What I could do is make it dlopen() the shared library if available, that way the support is optional.

Note that dupd is not usually (although it can happen) hash-speed limited, so in most cases it probably won't see much difference. But always interesting to try.

@jvirkki jvirkki self-assigned this Mar 6, 2018
@jbruchon
Copy link
Contributor

FWIW I switched from my jodyhash to xxHash64 because it's faster and is a simple .c/.h file pair with an easy C interface.

@jvirkki
Copy link
Owner

jvirkki commented Jul 7, 2019

Same, dupd switched to xxHash back in 1.6. Works quite well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants