Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add broken link checker #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add broken link checker #28

wants to merge 1 commit into from

Conversation

iamrajiv
Copy link
Member

@iamrajiv iamrajiv commented Sep 6, 2022

Fixes: #27
Related: keptn/keptn.github.io#994

Issue template for the broken link will look like this

Screenshot 2022-09-06 at 6 51 11 AM

Report for the broken links will look like this

Screenshot 2022-09-06 at 6 51 51 AM

.github/workflows/markdown.links.config.json file is use for specifying a custom configuration file for markdown-link-check. You can use it to remove false positives by specifying replacement patterns.

Signed-off-by: Rajiv Ranjan Singh <[email protected]>
@netlify
Copy link

netlify bot commented Sep 6, 2022

Deploy Preview for keptn-experimental-docs-site ready!

Name Link
🔨 Latest commit 4eb8d8f
🔍 Latest deploy log https://app.netlify.com/sites/keptn-experimental-docs-site/deploys/6316f9483a887a0008de0b06
😎 Deploy Preview https://deploy-preview-28--keptn-experimental-docs-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@iamrajiv iamrajiv requested a review from vadasambar September 6, 2022 07:40
@github-actions
Copy link

github-actions bot commented Sep 6, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 40
🟢 Accessibility 100
🟢 Best practices 93
🟢 SEO 90
🟠 PWA 64

Lighthouse ran on https://deploy-preview-28--keptn-experimental-docs-site.netlify.app/

@iamrajiv iamrajiv mentioned this pull request Sep 6, 2022
21 tasks
"replacementPatterns": [
{
"pattern": "^/",
"replacement": "https://keptn-experimental-docs-site.netlify.app/"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we doing this ^ @iamrajiv ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussion with @iamrajiv , he's going to try this out ^ and show us the results here with a before and after (replacement) in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add broken link checker
2 participants