Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor LocalDateTime#nextMatch logic #28

Open
kevincianfarini opened this issue Jan 19, 2024 · 1 comment
Open

Refactor LocalDateTime#nextMatch logic #28

kevincianfarini opened this issue Jan 19, 2024 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@kevincianfarini
Copy link
Owner

The current implementation is brittle and potential contains bugs like #26. We should try to find a reference cron test suite we can assert against.

@kevincianfarini
Copy link
Owner Author

This refactor should also take into account how to support multiple, non-contiguous values. For example:

5,10 0 10 * 1 

In cron this will run a task at 12:05 and 12:10 on every Monday as well as on the 10th of every month. The current representation of int ranges for the datetime matching forbids us from specifying 5,10.

@kevincianfarini kevincianfarini added bug Something isn't working enhancement New feature or request labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant