Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commit_transaction #416

Open
2 tasks
Tracked by #357
Eikix opened this issue Jan 15, 2025 · 1 comment · May be fixed by #487
Open
2 tasks
Tracked by #357

commit_transaction #416

Eikix opened this issue Jan 15, 2025 · 1 comment · May be fixed by #487
Milestone
EELS migration

Comments

@Eikix
Copy link
Member

Eikix commented Jan 15, 2025 •
edited by ClementWalter
Loading

  • remove the X_snapshots from state and transient storage as we have another mechanism with original_mapping
  • call hashdict_finalize(merge=TRUE) recursively for all dicts
@github-project-automation github-project-automation bot moved this to Backlog in Keth Jan 15, 2025
@Eikix Eikix mentioned this issue Jan 15, 2025
Open
@obatirou obatirou moved this from Backlog to In progress in Keth Jan 17, 2025
@obatirou obatirou self-assigned this Jan 17, 2025
@obatirou obatirou moved this from In progress to In review in Keth Jan 17, 2025
@obatirou obatirou linked a pull request Jan 17, 2025 that will close this issue
Draft
@obatirou obatirou moved this from In review to In progress in Keth Jan 17, 2025
@Eikix Eikix added the blocked Blocked by an external dependency label Jan 20, 2025
@Eikix
Copy link
Member Author

Eikix commented Jan 20, 2025

Blocked for now as discussed with @enitrat and @obatirou until we spec out how to handle properly copying dicts.

@Eikix Eikix added this to the EELS migration milestone Jan 20, 2025
@ClementWalter ClementWalter moved this from In progress to In review in Keth Jan 20, 2025
@ClementWalter ClementWalter moved this from In review to Backlog in Keth Jan 20, 2025
@ClementWalter ClementWalter removed the blocked Blocked by an external dependency label Jan 20, 2025
@ClementWalter ClementWalter moved this from Backlog to Todo in Keth Jan 20, 2025
@obatirou obatirou removed their assignment Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Keth
Status: Todo
Milestone
EELS migration
Development

Successfully merging a pull request may close this issue.

feat: commit transaction kkrt-labs/keth
3 participants
@ClementWalter @Eikix @obatirou